[dolphin] [Bug 449211] Detail View mode doesn't support RTL properly

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=449211

Felix Ernst <felixernst at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|https://invent.kde.org/syst |https://invent.kde.org/syst
                   |em/dolphin/commit/ddba4f5fd |em/dolphin/-/commit/95542a3
                   |88c4fa855e3f2eb0d9d95a6290d |89112491abf3a31c338e7d78f77
                   |150a                        |85f48e

--- Comment #6 from Felix Ernst <felixernst at kde.org> ---
Git commit 95542a389112491abf3a31c338e7d78f7785f48e by Felix Ernst.
Committed on 29/12/2024 at 11:42.
Pushed by felixernst into branch 'master'.

Mirror details view mode for right-to-left languages

This commit implements mirroring of the details view mode for right-to-
left languages. This is the last of the Dolphin view modes which did
not adapt to right-to-left languages correctly.

Implementation-wise this is mostly about adapting the math so all the
information is placed correctly no matter the view mode or layout
direction. While most of the view actually changes the painting code
for right-to-left languages, for the column header I decided to keep
the logic left-to-right and instead reverse the order of the role
columns.

To implement this mirroring I needed to rework quite a bit of logic, so
I used the opportunity to fix some bugs/behaviur quirks:
- Left and right padding is now saved and restored separately instead
  of only saving the left padding
- Changing the right padding no longer disables "automatic column
  resizing".
- The grip handles for column resizing can now be grabbed when near the
  grip handle instead of only allowing grabbing when slightly to the
  left of the grip.
- Role column headers now only show a hover highlight effect when the
  mouse cursor is actually above that role and not above the grip
  handle or the padding.
- There is now a soft-boarder when shrinking the right padding so
  shrinking the padding "below zero width" will no longer immediately
  clear automatic resize behaviour. So now it is possible to simply
  remove the right padding by resizing it to zero width.
Related: bug 495942

# Acknowledgement

This work is part of a my project funded through the NGI0 Entrust Fund,
a fund established by NLnet with financial support from the European
Commission's Next Generation Internet programme, under the aegis of DG
Communications Networks, Content and Technology.

M  +14   -28   src/kitemviews/kitemlistcontroller.cpp
M  +10   -5    src/kitemviews/kitemlistheader.cpp
M  +5    -4    src/kitemviews/kitemlistheader.h
M  +6    -6    src/kitemviews/kitemlistview.cpp
M  +30   -11   src/kitemviews/kitemlistwidget.cpp
M  +6    -4    src/kitemviews/kitemlistwidget.h
M  +48   -25   src/kitemviews/kstandarditemlistwidget.cpp
M  +2    -1    src/kitemviews/kstandarditemlistwidget.h
M  +182  -144  src/kitemviews/private/kitemlistheaderwidget.cpp
M  +25   -12   src/kitemviews/private/kitemlistheaderwidget.h
M  +6    -2    src/settings/dolphin_detailsmodesettings.kcfg
M  +7    -1    src/settings/dolphin_detailsmodesettings.upd
M  +9    -4    src/settings/viewmodes/viewsettingstab.cpp
M  +10   -5    src/views/dolphinview.cpp
M  +1    -1    src/views/dolphinview.h

https://invent.kde.org/system/dolphin/-/commit/95542a389112491abf3a31c338e7d78f7785f48e

-- 
You are receiving this mail because:
You are on the CC list for the bug.