[dolphin] [Bug 458091] Make multiple selection keyboard navigable

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=458091

Felix Ernst <felixernst at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/-/commit/3696213
                   |                            |ccbbe27e9ef3fc85eb97dd32fd6
                   |                            |69066f

--- Comment #4 from Felix Ernst <felixernst at kde.org> ---
Git commit 3696213ccbbe27e9ef3fc85eb97dd32fd669066f by Felix Ernst.
Committed on 29/12/2024 at 11:27.
Pushed by felixernst into branch 'master'.

Have special keyboard controls in selection mode

Prior to this commit keyboard controls and behaviour of Dolphin's main
view were identical no matter if selection mode was enabled or not.
While selection mode makes it impossible to accidentally clear the
selection by singular mouse clicks, any press of an arrow key on the
keyboard would still clear the full selection which goes against
selection mode's objective.

Furthermore, keyboard-only users had no reason to ever enable selection
mode because it made no difference to them.

This commit changes this by offering a changed control scheme for key
presses while in selection mode. Arrow key presses without modifier now
only move focus between items but do no longer clear or change the
selection. Similarly, Page Up/Down, Home, and End key presses only move
keyboard focus. Enter, Return, and Space key presses now only toggle
the selection for the current item.

The above controls are however mostly unchanged when combining them
with Modifier keys like Shift or Control.

The type-ahead feature is also changed in selection mode to only move
keyboard focus without changing the selection.

This way keyboard users are less likely to clear their selection by
mistake. Regression tests are added for these selection mode controls.

The code changes to change this keyboard behaviour are quite minimal.
Most of the added code is for making selection mode accessible. That's
because we need to make sure the changed control scheme is properly
announced and communicated or a blind user will be left utterly
confused why the normal keyboard controls "stopped working".

Enabling or disabling selection mode is announced to accessibility
software. Furthermore whenever focus goes to the main view, the
selection mode state is also mentioned when active.

M  +31   -0    src/kitemviews/accessibility/kitemlistviewaccessible.cpp
M  +7    -0    src/kitemviews/accessibility/kitemlistviewaccessible.h
M  +13   -5    src/kitemviews/kitemlistcontroller.cpp
M  +20   -11   src/selectionmode/topbar.cpp
M  +2    -0    src/selectionmode/topbar.h
M  +92   -3    src/tests/kitemlistcontrollertest.cpp
M  +6    -0    src/views/dolphinview.cpp

https://invent.kde.org/system/dolphin/-/commit/3696213ccbbe27e9ef3fc85eb97dd32fd669066f

-- 
You are receiving this mail because:
You are on the CC list for the bug.