[dolphin] [Bug 497555] Dolphin is not automatically updating previews after changing file's name since 24.12

Akseli Lahtinen bugzilla_noreply at kde.org
Thu Dec 19 15:59:54 GMT 2024


https://bugs.kde.org/show_bug.cgi?id=497555

Akseli Lahtinen <akselmo at akselmo.dev> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/syst |https://invent.kde.org/syst
                   |em/dolphin/-/commit/eca160a |em/dolphin/-/commit/0fe6544
                   |e5a2dbd5590e4bae22cddde488d |079a23769e8f19ee2f09b5c149f
                   |bacf74                      |404d5a

--- Comment #10 from Akseli Lahtinen <akselmo at akselmo.dev> ---
Git commit 0fe6544079a23769e8f19ee2f09b5c149f404d5a by Akseli Lahtinen.
Committed on 19/12/2024 at 15:52.
Pushed by akselmo into branch 'release/24.12'.

dolphinview: Update thumbnail on filename change

If filename of an item was updated previously, it would modify the model
before the file was actually changed. This led to the model calling
a signal that would try to run a previewjob, but since the filename
is not actually changed yet on disk, it would fail.

This patch moves the model updating after copyjob. Copyjob
will take care of the file renaming if there is already existing file.
We just need to update the model correctly after the job has succeeded.

(cherry picked from commit eca160ae5a2dbd5590e4bae22cddde488dbacf74)

M  +1    -0    src/kitemviews/kfileitemlistview.h
M  +1    -0    src/kitemviews/kfileitemmodelrolesupdater.cpp
M  +3    -0    src/kitemviews/kfileitemmodelrolesupdater.h
M  +2    -0    src/kitemviews/kitemlistview.h
M  +49   -0    src/tests/dolphinmainwindowtest.cpp
M  +8    -17   src/views/dolphinview.cpp

https://invent.kde.org/system/dolphin/-/commit/0fe6544079a23769e8f19ee2f09b5c149f404d5a

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the kfm-devel mailing list