[dolphin] [Bug 495878] Customizing the default view settings doesn't work anymore

Akseli Lahtinen bugzilla_noreply at kde.org
Mon Dec 16 21:54:33 GMT 2024


https://bugs.kde.org/show_bug.cgi?id=495878

Akseli Lahtinen <akselmo at akselmo.dev> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/syst |https://invent.kde.org/syst
                   |em/dolphin/-/commit/8d15555 |em/dolphin/-/commit/86609f8
                   |8e980197b4dc2180660ea9bc61a |9358243c08ebe4de8498a0fa6df
                   |23f3d3                      |f8370e

--- Comment #9 from Akseli Lahtinen <akselmo at akselmo.dev> ---
Git commit 86609f89358243c08ebe4de8498a0fa6dff8370e by Akseli Lahtinen.
Committed on 16/12/2024 at 20:52.
Pushed by akselmo into branch 'release/24.12'.

ViewProperties: Return nullptr if viewPropertiesString is empty

If viewPropertiesString is empty, return a nullptr.
This will later used in the stack by the defaultProperties call.

In defaultProperties, if we can't find the global directory,
create new one with a tempfile. If tempfiles can't be created,
use default instead.

This will ensure that view settings are saved and loaded correctly
if user has separate view properties per folder.

This will also add an unit test, where we create a global directory,
modify it and make sure the changes are reflected in the unmodified
folder.


(cherry picked from commit 8d155558e980197b4dc2180660ea9bc61a23f3d3)

97d9a70c ViewProperties: Return nullptr if viewPropertiesString is empty
60a3da35 Create lambda for creating temporary files

Co-authored-by: Akseli Lahtinen <akselmo at akselmo.dev>

M  +69   -6    src/tests/viewpropertiestest.cpp
M  +39   -20   src/views/viewproperties.cpp

https://invent.kde.org/system/dolphin/-/commit/86609f89358243c08ebe4de8498a0fa6dff8370e

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the kfm-devel mailing list