[frameworks-kio] [Bug 466115] Custom horizontal lines/bars in context menu no longer possible

[Alexander Lohnau]

https://bugs.kde.org/show_bug.cgi?id=466115

Alexander Lohnau <alexander.lohnau at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kio/-/commit/b154c9d
                   |                            |2f4fc86e6efdcf50bd11bba1f4a
                   |                            |365033

--- Comment #9 from Alexander Lohnau <alexander.lohnau at gmx.de> ---
Git commit b154c9d2f4fc86e6efdcf50bd11bba1f4a365033 by Alexander Lohnau, on
behalf of Robert-André Mauchin.
Committed on 27/04/2024 at 15:24.
Pushed by alex into branch 'master'.

KFileItemActions: Add logic to order actions between separators

Commit 337853329c61c9cfe5e369acf65a8eca94e5e7fd has purposedly ordered
actions by their name. However, this breaks separators in service context
menus.

For example:

Actions=progressive;optimize;\_SEPARATOR\_;compress_50;compress_70;compress_75

The separator would end up at the end of the list:

Actions=compress_50;compress_70;compress_75;progressive|optimize;\_SEPARATOR\_

And since the logic check if the separator is the last item to add it:

!actions.last()->isSeparator()

separators basically disappear from service context menus.

The purpose of this commit is then to create groups of actions between
each separator. Actions will be sorted within these groups, but it will
keep service menus original order.

M  +47   -18   src/widgets/kfileitemactions.cpp

https://invent.kde.org/frameworks/kio/-/commit/b154c9d2f4fc86e6efdcf50bd11bba1f4a365033

-- 
You are receiving this mail because:
You are on the CC list for the bug.