[dolphin] [Bug 480246] Column sorting is reset when moving to a different dir

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=480246

Méven Car <meven.car at kdemail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/-/commit/13cf4c0
                   |                            |96fc673e43a22746342d25c506b
                   |                            |de8405

--- Comment #3 from Méven Car <meven.car at kdemail.net> ---
Git commit 13cf4c096fc673e43a22746342d25c506bde8405 by Méven Car, on behalf of
Felix Ernst.
Committed on 09/04/2024 at 05:53.
Pushed by meven into branch 'master'.

Fix saving sort role after change from header

This is a partial revert of
5186f09cabf0af4b0683e75b0bcde1061f84a67e. That commit tried to
simplify code, however this lead to the saving of view properties
being skipped, introducing the linked bug.

The issue is that by the time the slotSortRoleChangedFromHeader()
method is called, the model already changed its sort role.
Therefore the check if the new role is identical to the old sort
role fails and no saving would occur.

With this partial revert the header will continue to change the
sort role itself (which allows a minor optimization of not double
sorting when also changing the sort order at the same time). The
method slotSortRoleChangedFromHeader() is then only responsible
for saving that change in the ViewProperties and telling the
SortBy menu in the user interface that the sorting has changed.

M  +4    -1    src/views/dolphinview.cpp

https://invent.kde.org/system/dolphin/-/commit/13cf4c096fc673e43a22746342d25c506bde8405

-- 
You are receiving this mail because:
You are on the CC list for the bug.