[dolphin] [Bug 463594] Dolphin crashed when trying to share folder

[Nicolas Fella]

https://bugs.kde.org/show_bug.cgi?id=463594

Nicolas Fella <nicolas.fella at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/kdenetwork-filesharing/
                   |                            |commit/5a1111098277128482b7
                   |                            |7f28c8c08f3f88f606d7
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Nicolas Fella <nicolas.fella at gmx.de> ---
Git commit 5a1111098277128482b77f28c8c08f3f88f606d7 by Nicolas Fella.
Committed on 01/01/2023 at 23:01.
Pushed by nicolasfella into branch 'master'.

Don't exec() the StatJob

exec() spawns a nested event loop, which is very problematic

In particular here it causes a crash when the job is running when the window is
closed

By using coroutines and QCoro we can achieve the API convenience of exec()
without using nested event loops

M  +1    -0    .kde-ci.yml
M  +5    -1    CMakeLists.txt
M  +1    -0    samba/filepropertiesplugin/CMakeLists.txt
M  +18   -7    samba/filepropertiesplugin/permissionshelper.cpp
M  +3    -0    samba/filepropertiesplugin/permissionshelper.h

https://invent.kde.org/network/kdenetwork-filesharing/commit/5a1111098277128482b77f28c8c08f3f88f606d7

-- 
You are receiving this mail because:
You are on the CC list for the bug.