[dolphin] [Bug 463931] "Show Target" action for symbolic links often opens multiple new windows

[Nicolas Fella]

https://bugs.kde.org/show_bug.cgi?id=463931

Nicolas Fella <nicolas.fella at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
                   |eworks/kio/commit/71c0763c1 |eworks/kio/commit/e8a7a6c83
                   |5fa35ea74aef3d1f89ba112af28 |e8725a73cb4c90b572315594a58
                   |4bd6                        |f65c

--- Comment #5 from Nicolas Fella <nicolas.fella at gmx.de> ---
Git commit e8a7a6c83e8725a73cb4c90b572315594a58f65c by Nicolas Fella, on behalf
of Jin Liu.
Committed on 17/02/2023 at 12:55.
Pushed by nicolasfella into branch 'kf5'.

OpenFileManagerWindowJob: fix opening multiple instances under Wayland [KF5]

The Problem:
Under wayland, when there's only one Dolphin window, "Show Target" in
Dolphin's right click menu opens multiple duplicate Dolphin windows.

The Cause:
DolphinMainWindow::showTarget
=> KIO::OpenFileManagerWindowJob::highlightInFileManager
=> KWindowSystem::requestXdgActivationToken
=> on KWindowSystem::xdgActivationTokenArrived signal
=> dbus call org.freedesktop.FileManager1 ShowItems
=> Dolphin::DBusInterface::ShowItems
=> Dolphin::openNewWindow
=> KIO::ApplicationLauncherJob
=> KIO::KProcessRunner
=> Calls KWindowSystem::requestXdgActivationToken under Wayland. Loop.

The Fix:
Call QObject::disconnect() first in the slot to disconnect the signal.

M  +1    -0    src/widgets/openfilemanagerwindowjob.cpp

https://invent.kde.org/frameworks/kio/commit/e8a7a6c83e8725a73cb4c90b572315594a58f65c

-- 
You are receiving this mail because:
You are on the CC list for the bug.