[frameworks-kconfigwidgets] [Bug 452527] Dolphin crashes after closing it by clicking the Close Tab option in KCommandBar

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=452527

Ahmad Samir <a.samirh78 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.94
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kconfigwidgets/commi
                   |                            |t/556f3b719ddecbf01eacaa286
                   |                            |ce609e8322ed870
             Status|CONFIRMED                   |RESOLVED

--- Comment #4 from Ahmad Samir <a.samirh78 at gmail.com> ---
Git commit 556f3b719ddecbf01eacaa286ce609e8322ed870 by Ahmad Samir.
Committed on 05/05/2022 at 09:41.
Pushed by ahmadsamir into branch 'master'.

KCommandBar: remove installed event filter in destructor

- Start Dolphin, Ctrl+Alt+I to invoked the KCommandBar
- Click "Close tab" (crash doesn't happen when you press Enter)
- Dolphin is being closed, KCommandBar is being torn down
- The eventFilter() tries to access d, which already have been destroyed
  down, which causes Dolphin to segfault and crash

This similar to the issue described here:
https://blogs.kde.org/2021/02/20/uniqueptr-difference-between-libstdc-and-libc-crashes-your-application

The gist of it is, always remove all installed event filters on child
widgets of the private class in the public class's desructor.
FIXED-IN: 5.94

M  +7    -0    src/kcommandbar.cpp

https://invent.kde.org/frameworks/kconfigwidgets/commit/556f3b719ddecbf01eacaa286ce609e8322ed870

-- 
You are receiving this mail because:
You are on the CC list for the bug.