[dolphin] [Bug 451926] New: "Git Remove" should default to "git rm --cached"

[bugzilla_noreply at kde.org]

https://bugs.kde.org/show_bug.cgi?id=451926

            Bug ID: 451926
           Summary: "Git Remove" should default to "git rm --cached"
           Product: dolphin
           Version: 19.12.3
          Platform: Ubuntu Packages
                OS: Linux
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: plugins: git
          Assignee: sebastian at sebastian-doerner.de
          Reporter: kevin at dotmon.com
                CC: kfm-devel at kde.org
  Target Milestone: ---

The right-click "Git Add" in this plugin adds the file/folder to the staging
area.  It might logically be expected that the accompanying "Git Remove" would
remove the file/folder from the staging area (but keep it on-disk in the
working folder).  However, it not only removes the file/folder from the staging
area BUT ALSO deletes it from the working folder.  Nor is the deleted
file/folder available in the wastebin.  It would be safer (and more logical) to
have the "Git Remove" option default to "git rm ---cached" instead of "git rm".

This is raising the same issue as https://bugs.kde.org/show_bug.cgi?id=414342,
where a fix was proposed: https://phabricator.kde.org/D25431.  However, that
fix has been marked as "requires changes to proceed" since 2020, and it looks
as if the fix was never applied to the plugin, hence my raising it again.  If
using --cached by default causes problems as referred to by David Edmundson, I
would suggest a sensible approach in the meantime would be to raise a dialogue
box saying "This will nuke your files - do you REALLY want to do this?", with a
Yes/No answer.  The git fsck approach suggested by Nate Graham does not work
with (eg) pdfs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.