[dolphin] [Bug 450813] "Dolphin" crashes when dragging a file to the top of the Places-Panel

[snx]

https://bugs.kde.org/show_bug.cgi?id=450813

--- Comment #3 from snx <snx at mailbox.org> ---
Git commit fc95fed526f59b70ea93c5e81680ffd0dec05c61 by snooxx 💤.
Committed on 03/03/2022 at 09:06.
Pushed by broulik into branch 'master'.

KFilePlacesView: Fix potential crash in `previousVisibleIndex`

The previous commit fixed a crash in
`KFilePlacesViewDelegate::previousVisibleIndex`, where access to `model`
failed due to an invalid index.

In addition to the previous commit already fixing the crash, unrelated
potential crashes in the future can be avoided by checking for an
invalid `index` in `previousVisibleIndex`. The existing logic of
`indexIsSectionHeader` is kept intact, since now an invalid `index` will
lead to comparing two empty strings, i.e. it will not be considered a
section header as required by the rest of the code.

This fix alone would already solve the crash without any side effects,
still introducing `m_dropIndex` seemed less brittle.
Related: bug 450966

Test Plan:

Functionality related to dragging places around (including existing
bugs) is unaffected.

M  +1    -1    src/filewidgets/kfileplacesview.cpp

https://invent.kde.org/frameworks/kio/commit/fc95fed526f59b70ea93c5e81680ffd0dec05c61

-- 
You are receiving this mail because:
You are on the CC list for the bug.