[frameworks-kio] [Bug 433347] Dolphin crashes when closing new file dialog in remote location

[Nicolas Fella]

https://bugs.kde.org/show_bug.cgi?id=433347

Nicolas Fella <nicolas.fella at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kio/commit/c6e7a06cd
                   |                            |3dcb5f148b49a4a08e7c7c76790
                   |                            |aabe
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #21 from Nicolas Fella <nicolas.fella at gmx.de> ---
Git commit c6e7a06cd3dcb5f148b49a4a08e7c7c76790aabe by Nicolas Fella.
Committed on 06/02/2022 at 14:25.
Pushed by nicolasfella into branch 'master'.

[knewfilemenu] Bind stat job connection lifetime to dialog, not the whole menu

The stat job is asynchronous so it may end after the dialog is closed and
deleted.

In the slot we are accessing children of the dialog which then can lead to a
crash

Change the third parameter in the connect to the dialog instead of the menu to
automatically disconnect the connection when the dialog is destroyed

Thanks to Harald Sitter for the investigation.

M  +5    -1    src/filewidgets/knewfilemenu.cpp

https://invent.kde.org/frameworks/kio/commit/c6e7a06cd3dcb5f148b49a4a08e7c7c76790aabe

-- 
You are receiving this mail because:
You are on the CC list for the bug.