D20532: Proof of Concept: Add double click actions to empty space in the folder view

George Florea Banus noreply at phabricator.kde.org
Sat Feb 5 10:56:20 GMT 2022


fbg13 added a comment.


  In D20532#679477 <https://phabricator.kde.org/D20532#679477>, @meven wrote:
  
  > From  Elvis (dolphin maintainer):
  >
  > > The original patch had problems too, but if someone wants to improve it feel free to work on it.
  >
  > In the context it would be this diff here.
  >
  > So it just depend on contribution.
  >
  > There are been demand for this feature enough that Elvis, Nate or me would accept a patch as long as it is configurable.
  
  
  
  
  In D20532#679478 <https://phabricator.kde.org/D20532#679478>, @meven wrote:
  
  > In D20532#675987 <https://phabricator.kde.org/D20532#675987>, @elvisangelaccio wrote:
  >
  > > Here's a recap. I might accept the patch if:
  > >
  > > 1. The double-click triggers a single action. Could be "Go Up" like requested in the past or could be "Select All" like suggested on reddit. We should carefully choose which action to use.
  > > 2. The double-click does not trigger the action if the user misclicks an item, because that would be very annoying. An easy solution could be to only enable the feature in single-click mode. Proper solution would be to check whether the double-click happens near an item, for some definition of near.
  >
  >
  > That's what was mostly what was left to do on this diff btw.
  
  
  This makes it sound like the feature was accepted, but I didn't want to do the remaining work.
  elvisangelaccio was clearly against the feature from the beginning and he never said he'll accept the feature, even if all problems are fixed, just that he **might**.
  So I didn't wanna spend more time on something that most likely will be rejected.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20532

To: fbg13, #dolphin, elvisangelaccio, #vdg, ngraham
Cc: knecker, lbenes, ashark, emvaized, meven, maxts, dhaumann, rizzitello, anthonyfieroni, kneckermcknacksack, ngraham, kfm-devel, sdorishlab, badbunny, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, koehn, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kfm-devel/attachments/20220205/aa78d555/attachment.htm>


More information about the kfm-devel mailing list