[dolphin] [Bug 462845] The default button changed to Cancel at permanent delete

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=462845

Felix Ernst <felixernst at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kio/commit/da081e8bd
                   |                            |5d9fcea672c561dc23293ccf043
                   |                            |e3e6

--- Comment #23 from Felix Ernst <felixernst at kde.org> ---
Git commit da081e8bd5d9fcea672c561dc23293ccf043e3e6 by Felix Ernst.
Committed on 30/12/2022 at 12:13.
Pushed by felixernst into branch 'master'.

Pre-select "Delete" in Delete Confirmation Dialog

This commit makes the "Delete" button the default button in the dialog
for confirming direct deletion of a file and in the dialog for
confirming emptying of the trash.

This was accidentally changed in
8144733c5110c66922381f97829f9470b26c8122 while trying to change the
dialog styling to be more like a warning. Users were unhappy about this
because it broke their muscle memory of "Shift+Del" into "Return" to
permanently delete a file.

This "revert" changes the dialog type from "warning" back to
"question". However, this would also change the icon displayed in the
dialog so the icon is explicitly set to be the same as in the "warning"
dialog.

An alternative suggestion was to add explicit API to select the
pre-selected button but this didn't happen as part of this "revert".

M  +7    -4    src/widgets/widgetsaskuseractionhandler.cpp

https://invent.kde.org/frameworks/kio/commit/da081e8bd5d9fcea672c561dc23293ccf043e3e6

-- 
You are receiving this mail because:
You are on the CC list for the bug.