[dolphin] [Bug 457975] Click-and-hold enters Selection Mode, but tap-and-hold does not

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=457975

--- Comment #1 from Felix Ernst <fe.a.ernst at gmail.com> ---
>press-and-hold using a touch device should enter Selection Mode rather
>than showing the context menu

I agree, that is not implemented yet.

>Click-and-hold should generally do nothing when using a pointing device

I implemented that one based on Andy's feedback here:
https://invent.kde.org/system/dolphin/-/merge_requests/273#note_305006

Andy mentioned the advantage of this.
Not sure how bad the downsides of this are. One potential issue I see is that
users might be click-and-holding to begin a drag and drop operation and then be
surprised by selection mode triggering because they didn't move their mouse
fast enough. I had this tested and working originally. I just tested again if
this could be a problem and it currently is because of Bug 457973. But if that
bug was already fixed it probably wouldn't be.

I want to mention that removing the behaviour of entering selection mode when
click-and-holding is as easy as removing the line "        Q_EMIT
selectionModeChangeRequested(true);" here:
https://invent.kde.org/system/dolphin/-/blob/master/src/kitemviews/kitemlistcontroller.cpp#L1063
This would also fix Bug 457973. Easy profits!

For now we should probably figure out if we want click-and-hold with a pointing
device to enter selection mode or not because this might affect the necessary
implementation to fix the other touch device behaviour change that is being
requested here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.