D7700: Show list of tags in PlacesView

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> kossebau wrote in kfileplacesitem.cpp:351
> @nicolasfella Hi. this is passing the tag string both as translation context as well as the string to translate as well. Is this on purpose? Even more as the context parameter is ignored anyway and just there to force a context for the other cases being used with I18NC_NOOP values, to make sure a context is set at all.
> 
> So where are those tag names coming from, are they expected to be translated at all?

Tags are user-defined string and not supposed to be translated at all.

So yeah, passing the tag as a context makes no sense here. Most likely I didn't even understand the concept of a translation context at the time of writing

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7700

To: nicolasfella, #dolphin, #kde_applications, alexeymin, ngraham, broulik
Cc: kossebau, chehrlic, broulik, kde-frameworks-devel, bruns, rkflx, mmustac, spoorun, michaelh, renatoo, anthonyfieroni, cfeck, elvisangelaccio, emmanuelp, ngraham, alexeymin, #dolphin, sdorishlab, badbunny, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, koehn, cblack, fbampaloukas, alexde, Codezela, feverfew, meven, ahmadsamir, navarromorales, firef, andrebarros, rdieter, mikesomov, vkrause
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kfm-devel/attachments/20211125/7dca6d99/attachment-0001.htm>