[phonon-backend-vlc] [Bug 434506] Crash when attempting to play a video in the preview of the information panel with Phonon-VLC

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=434506

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/libr
                   |                            |aries/phonon-vlc/commit/f26
                   |                            |3063d1a9c748f92fa8cb021d8d8
                   |                            |a85bbace42

--- Comment #33 from Harald Sitter <sitter at kde.org> ---
Git commit f263063d1a9c748f92fa8cb021d8d8a85bbace42 by Harald Sitter.
Committed on 23/03/2021 at 10:12.
Pushed by sitter into branch '0.11'.

fix surface painting format setup

originally the format callback was not locked, but since we intercept
qwidget paints that meant we'd be able to receive paints before the
callback/setup had run. this could then result in a race condition where
if the user was quick enough, or supposedly the system under sufficient
load, that paints would be done on random blobs of invalid data. in
particular when the paint would happen right as the other thread was in
the format setup callback.

to deal with this simply lock the format callback function and ensure we
only paint when the frame has been constructed with actual data (frame
is non-null after the callback since we feed it the plane as data,
making it non-null)

M  +7    -1    src/video/videowidget.cpp

https://invent.kde.org/libraries/phonon-vlc/commit/f263063d1a9c748f92fa8cb021d8d8a85bbace42

-- 
You are receiving this mail because:
You are on the CC list for the bug.