[kio-extras] [Bug 430585] rename() falling over case insensitivity

Harald Sitter bugzilla_noreply at kde.org
Thu Mar 4 11:16:23 GMT 2021


https://bugs.kde.org/show_bug.cgi?id=430585

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/kio-extras/commit/ed0a8
                   |                            |e905df6c5e0ede3486f38afdb55
                   |                            |5ef80ce0
         Resolution|---                         |FIXED

--- Comment #4 from Harald Sitter <sitter at kde.org> ---
Git commit ed0a8e905df6c5e0ede3486f38afdb555ef80ce0 by Harald Sitter.
Committed on 04/03/2021 at 11:15.
Pushed by sitter into branch 'master'.

smb: do not assume rename files are different based on name

samba is transparently supporting case sensitivity/insensitivity based
on server capabilities so 'A' and 'a' may be the same file or not. To
that end when a rename operation would change the capitalization of a
file we need to do some extra work to figure out if that renaming would
constitute an overwrite or not. Specifically we'll need to stat the
source file and then compare the inode and device returned by libsmb to
figure out if they are the same file. If they are then this is an
in-place rename, not an overwrite and we'll skip over the error
conditions to do with the dst file already existing

M  +34   -3    smb/kio_smb_dir.cpp

https://invent.kde.org/network/kio-extras/commit/ed0a8e905df6c5e0ede3486f38afdb555ef80ce0

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the kfm-devel mailing list