[frameworks-kconfig] [Bug 430521] Dolphin doesn't restore to original size after resuming from maximized.

[Antonio Orefice]

https://bugs.kde.org/show_bug.cgi?id=430521

--- Comment #37 from Antonio Orefice <kokoko3k at gmail.com> ---
I bisected the issue, but even if i found the "bad" commit,
it is not much useful, because it just exposes a bug introduced earlier and i
cannot determine when using git bisect:

In the past, the location bar were under the tabs, near the places panel.
Then it was moved to the top and the users were not allowed to move it.
Then the "bad" commit (not bad at all)
50ca5af7e0ec460f9f004a3660efa10bb1dd8cb1, allowed users to move the location
bar where it was by simply removing the location bar from the main toolbar.

So, I understood that dolphinui.rc is NOT needed to reproduce the issue, it
just contained the information that the location bar was NOT present in the
main toolbar, and as soon as the commit landed, that setting took place
exposing the resize bug.

So the bad commit could be anywhere between:
37327c9b0aae112c5890703cba1f0157043007e0 (Make UrlNavigators in the toolbar the
only option)
and
50ca5af7e0ec460f9f004a3660efa10bb1dd8cb1 (Allow having the UrlNavigators below
the tab bar)


---------------------------------------------------------------------------------------
koko at Gozer# git bisect bad
50ca5af7e0ec460f9f004a3660efa10bb1dd8cb1 is the first bad commit
commit 50ca5af7e0ec460f9f004a3660efa10bb1dd8cb1
Author: Felix Ernst <fe.a.ernst at gmail.com>
Date:   Thu Nov 19 21:22:27 2020 +0000

    Allow having the UrlNavigators below the tab bar

    This commit restores the possibility to have the UrlNavigators below
    the tab bar. This will happen automatically whenever the UrlNavigator
    is removed from the toolbar.

    It is also now again possible to have the toolbar on the side. This
    option is disabled while the toolbar contains the UrlNavigators.

    This commit makes no changes to the new default which is having the
    UrlNavigators in the toolbar but makes sure that upgrading users won't
    be affected.

 src/dolphinmainwindow.cpp             | 35 ++++++++++++++++++---
 src/dolphinmainwindow.h               | 13 ++++++++
 src/dolphinnavigatorswidgetaction.cpp | 58 +++++++++++++++++------------------
 src/dolphinnavigatorswidgetaction.h   | 23 +++++++++-----
 src/dolphintabpage.cpp                | 23 ++++++++++++--
 src/dolphintabpage.h                  |  2 ++
 src/main.cpp                          |  7 -----
 7 files changed, 110 insertions(+), 51 deletions(-)
---------------------------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.