D21937: Use destinationDir to save viewproperties when not in global viewproperties setting

[Méven Car]

meven added a comment.


  In D21937#677041 <https://phabricator.kde.org/D21937#677041>, @elvisangelaccio wrote:
  
  > In D21937#497112 <https://phabricator.kde.org/D21937#497112>, @meven wrote:
  >
  > > In D21937#496989 <https://phabricator.kde.org/D21937#496989>, @elvisangelaccio wrote:
  > >
  > > > Sorry, I missed this one. I'd say let's postpone to 19.12...
  > >
  > >
  > > No worries
  > >
  > > Also we might want to discuss it a bit more, folder moving :
  > >
  > > > A limitation of the current patch is when a folder is moved, the settings are lost.
  > > >  I can imagine two potential solution :
  > > > 
  > > > - a "bazooka" solution : use inotify and consort to have the settings follow the files.
  > > > - a simple solution : use inode id as path in destinationDir for local files. That way if a folder is moved its settings follow. Although it won't survive network moves.
  > >
  > >
  > >
  > > > A third solution would be to store the view settings in an extended attribute on the folder itself. That wouldn't survive copying to or from filesystems that don't support xattrs though.
  >
  >
  > Not sure what to do here, honestly.
  >
  > - bazooka solution: sounds dangerous. And what if inotify is not available?
  
  
  
  
  > - inode id solution: doesn't look portable, what about Windows?
  > - xattr solution: same, not portable
  
  Well Windows has its own FS id https://docs.microsoft.com/fr-fr/windows/win32/api/fileapi/nf-fileapi-getfileinformationbyhandle?redirectedfrom=MSDN
  We could manage to have a compatibility logic.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D21937

To: meven, ngraham, elvisangelaccio, #dolphin
Cc: kfm-devel, badbunny, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kfm-devel/attachments/20210114/75bad9c8/attachment-0001.htm>