[dolphin] [Bug 446539] right-click open terminal here in Dolphin crashes Dolphin

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=446539

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kio/commit/98bffe880
                   |                            |9362e3cd3673da70aa451a09411
                   |                            |3850

--- Comment #2 from Harald Sitter <sitter at kde.org> ---
Git commit 98bffe8809362e3cd3673da70aa451a094113850 by Harald Sitter.
Committed on 17/12/2021 at 14:29.
Pushed by sitter into branch 'master'.

do not access service past its prime

service is only set when we actually resolved from a service, but
sometimes we resolve from path. refactor service resolution into a
helper function and scope it to the fallback if such that the rest of
the determine function no longer has access to the potentially null
service pointer.

also add a nasty bool switch to the private function so we can
synthesize the condition even when konsole is installed (i.e. the
majority of dev systems ;))

M  +24   -0    autotests/kterminallauncherjobtest.cpp
M  +1    -0    autotests/kterminallauncherjobtest.h
A  +3    -0    autotests/kterminallauncherjobtest/konsole
M  +17   -7    src/gui/kterminallauncherjob.cpp
M  +1    -1    src/gui/kterminallauncherjob.h

https://invent.kde.org/frameworks/kio/commit/98bffe8809362e3cd3673da70aa451a094113850

-- 
You are receiving this mail because:
You are on the CC list for the bug.