[dolphin] [Bug 439997] Hamburger menu should not be added to context menu if user uses a global menu applet

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=439997

Felix Ernst <fe.a.ernst at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kconfigwidgets/commi
                   |                            |t/233f3c25dc0b124c36ac616bc
                   |                            |ab7fa3b84315ecd
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.86

--- Comment #4 from Felix Ernst <fe.a.ernst at gmail.com> ---
Git commit 233f3c25dc0b124c36ac616bcab7fa3b84315ecd by Felix Ernst.
Committed on 23/08/2021 at 13:11.
Pushed by felixernst into branch 'master'.

Hide KHamburgerMenu in QMenus when a native menu bar is used

When a native menu bar is used, users normally don't need an
additional KHamburgerMenu in any QMenus.

This was already once before the behaviour in this scenario but it
was unnecessarily changed as a side-effect of
901b049ca48e35fe9df07092a8657b1578fad300.

While the m_menuAction can be used as a normal menu by users that
don't mind invoking a QMenu to access any menu actions, its primary
use really is that of a fallback.
Therefore the existence of a native menu bar (no matter what shape
or size it might have) is enough reason for us to hide m_menuAction.
FIXED-IN: 5.86

M  +16   -2    src/khamburgermenu.cpp
M  +2    -0    src/khamburgermenu.h
M  +2    -1    src/khamburgermenu_p.h

https://invent.kde.org/frameworks/kconfigwidgets/commit/233f3c25dc0b124c36ac616bcab7fa3b84315ecd

-- 
You are receiving this mail because:
You are on the CC list for the bug.