[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=435731

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |CONFIRMED
     Ever confirmed|0                           |1
                 CC|                            |sitter at kde.org

--- Comment #6 from Harald Sitter <sitter at kde.org> ---
https://invent.kde.org/system/dolphin/-/commit/e9a39700fc004004b1ff231023e9d5333a2b8317

The padding is only applied IFF an explicit size has been set, and the way the
settings behave is that when you go to medium and then small it will not remove
the explicit size but set it to 16 (which honestly is a bit of a bug in of
itself).

i.e. a "new" dolphinrc is not the same as a dolphinrc that changed the size at
least once.

If you remove your dolphinrc and start from a clean state the bug should be
reproducible. Once you switched back to Small the config contains:

[PlacesPanel]
IconSize=16

Which then triggers the PlacesView::setIconSize call which then inject
artificial padding forever more.

The problem here really is that the commit I linked to is wrong. It shouldn't
set the padding in the setIconSize, it should set it in the constructor. The
padding never changes, there is no reason for it to be set over and over again
to the same value.

-- 
You are receiving this mail because:
You are on the CC list for the bug.