[frameworks-kio] [Bug 435559] Dolphin crashes trying to change location of Trash Places panel item

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=435559

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.12.3                     |git master
           Assignee|dolphin-bugs-null at kde.org   |kio-bugs-null at kde.org
                 CC|                            |kdelibs-bugs at kde.org,
                   |                            |sitter at kde.org
          Component|panels: places              |Places
            Product|dolphin                     |frameworks-kio

--- Comment #8 from Harald Sitter <sitter at kde.org> ---
Crash is actually in KIO.

KFilePlaceEditDialog::icon() there is a guard against paths with immutable icon
(KFilePlaceEditDialog::isIconEditable()) but also based on that guard
m_iconButton will not be initialized.

i.e. When one edits the Trash entry the url is trash:/ and guarded so
m_iconButton is nullptr after the ctor. When one then changes the url to
anything but trash:/ the guard gets deactivated and any call into ::icon() will
dereference the nullptr.

One can but wonder what the point of editing the trash url is exactly though.
I'd disable it TBH.

Other solutions:
- do not check the guard after construction. if the url was for an immutable
icon on construction it'll be considered immutable forever more. kinda meh
though
- update the iconbutton on urlChanged(). i.e. delete when url changes to
trash:/, construct when it changes away from trash:/

-- 
You are receiving this mail because:
You are on the CC list for the bug.