[frameworks-kcoreaddons] [Bug 423818] KDirWatch's useFam loops indefinitely (actual fam, not gamin)

Harald Sitter bugzilla_noreply at kde.org
Tue Sep 22 14:03:39 BST 2020


https://bugs.kde.org/show_bug.cgi?id=423818

--- Comment #20 from Harald Sitter <sitter at kde.org> ---
Git commit 7223eaa5c5a662e6da6bf8190b41acb9bd8a50d8 by Harald Sitter.
Committed on 22/09/2020 at 11:03.
Pushed by sitter into branch 'master'.

fix(kded): move to kdirwatch to reduce inotify footprint

Each QFileSystemWatch claims its own inotify instance. This is
problematic because there is a default limit of 127 instances per user,
fivolously claiming instances is therefore really poor behavior.

KDirWatch meanwhile shares the same underlying instance behind the scene
so each thread would only have a single instance with N different
watches on it.

Moving to KDW effectively reduces the inotify instance footprint of the
kded module from N per Control to 0 since kded always has a kdirwatch
for ksyscoca/kservice monitoring and our KDW is backed by the same
instance.

M  +5    -4    common/control.cpp
M  +3    -3    common/control.h
M  +1    -1    tests/kded/CMakeLists.txt

https://invent.kde.org/plasma/kscreen/commit/7223eaa5c5a662e6da6bf8190b41acb9bd8a50d8

-- 
You are receiving this mail because:
You are on the CC list for the bug.



More information about the kfm-devel mailing list