[dolphin] [Bug 158934] Media ejecting fails to update the location bar

[Riccardo Robecchi]

https://bugs.kde.org/show_bug.cgi?id=158934

Riccardo Robecchi <sephiroth_pk at hotmail.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sephiroth_pk at hotmail.it

--- Comment #19 from Riccardo Robecchi <sephiroth_pk at hotmail.it> ---
(In reply to Elvis Angelaccio from comment #18)
> Git commit ae1d441dacef7e52984201abdc9a918ce060021c by Elvis Angelaccio, on
> behalf of Nate Graham.
> Committed on 23/10/2020 at 17:00.
> Pushed by elvisangelaccio into branch 'master'.
> 
> Show home folder if needed after unmounting mounted disk
> 
> Right now, when you unmount a device that any active view containers are
> displaying, nothing in the view changes. As a result, it's possible to
> try to navigate to files or folders in that view, which cannot be done
> because the disk that the files or folders are located on has been
> unmounted!
> 
> With this commit, we detect that case and switch the view containers
> to show the home folder after the disk whose contents they are displaying
> gets unmounted.
> FIXED-IN: 20.12
> 
> M  +19   -0    src/dolphinmainwindow.cpp
> M  +9    -1    src/dolphinmainwindow.h
> M  +3    -0    src/panels/places/placesitemmodel.cpp
> M  +1    -0    src/panels/places/placesitemmodel.h
> M  +2    -0    src/panels/places/placespanel.cpp
> M  +1    -0    src/panels/places/placespanel.h
> 
> https://invent.kde.org/system/dolphin/commit/
> ae1d441dacef7e52984201abdc9a918ce060021c

I honestly don't find this an improvement - if anything, I find this a
regression. It has happened to me that a disk was unmounted without me noticing
(e.g. because of an issue with the cable I was using). Having an error message
was actually useful to realise that something was not working. If you redirect
users to the /home folder, there's no indication that the position they were in
is not available anymore; plus, the user does not reasonably expect to see the
/home folder after a device or folder has been unmounted.
There is also a peculiar, but nonetheless valid, use case in not being moved
away from the folder: if you need to unmount a device and then remount it, it
is rather useful to not have to navigate a possibly intricate tree of folders
again. With the current behaviour you can just update the view; with the new
one, you have to navigate again to the desired position.
I know this is a bit like XKCD's famous "I press the space bar to heat my room"
thing, but I am really opposed to the new behaviour as it does not solve the
issue and just sidesteps it with a solution that doesn't feel right.

-- 
You are receiving this mail because:
You are on the CC list for the bug.