Mount Iso service for dolphin

[Elvis Angelaccio]

On 15/05/20 16:29, Kwon-Young Choi wrote:
> Hello,
> 

Hi :)

> I've made a plugin for dolphin to mount or unmount an iso image file using the right-click contextual menu of an iso file.
> 
> First, here is the code: https://github.com/kwon-young/mount-iso
> 
> I use udisksctl and losetup to do this (See the README for more precision on how this works).
> 
> From what I have read in this bug report https://bugs.kde.org/show_bug.cgi?id=175051, I think there is interest to have this feature by default in dolphin.
> However, there seems to be a preference to use fuseiso instead of udisksctl to mount the iso image.
> Although using fuseiso is blocked by https://phabricator.kde.org/D21235 so that fuseiso filesystem are detected by dolphin.
> 
> Since this is my first time contributing to kde, I have a some questions:
> 
> * Should we use fuseiso or udisksctl and why? For now, I have settled on udisksctl because it works well now, but I can modify this code to use fuseiso with no problem, although the user interaction changes because we have asks the user where to mount the fuseiso filesystem.

If udisksctl works, go for it. We can always switch to fuseiso later, if
solid gains support for it.

> * In which kde project should this plugin go? For now, I have created a project on github so that anybody can see the code but I suppose if this contribution is accepted, it should move somewhere else.

I'd say it could go in dolphin-plugins.

> * How can I open a phabricator diff of this feature?

phabricator has been discontinued, we are now switching to gitlab:
https://invent.kde.org

> * Is the gpl v2 licence correct?

That's up to you, but I'd use the same license of e.g. dolphin-plugins.

> * Using QProcess to interface with udisksctl and losetup is not very clean. Can the equivalent be done using the kde Solid framework?

Probably not, but I'm no Solid expert.

> 
> I hope this will interest someone!
> 
> Best regards,
> 
> Kwon-Young Choi
> 

Cheers,
Elvis