D29788: [svn] Added basic svn commands logging output.

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> fileviewsvnplugin.cpp:347
>  {
> +    SvnProgressDialog *progress = new SvnProgressDialog(i18nc("@title:window", "SVN Update"));
> +    progress->connectToProcess(&m_process);

naming : dialog or progressDialog but progress is not descriptive

> fileviewsvnplugin.cpp:448
>  
> +    SvnProgressDialog *progress = new SvnProgressDialog(i18nc("@title:window", "SVN Revert"));
> +    progress->connectToProcess(&m_process);

Same

> svnprogressdialog.cpp:108
> +
> +void SvnProgressDialog::reject()
> +{

Not connected.

> svnprogressdialog.h:47
> +signals:
> +    void cancelPressed();
> +

Not used yet, I guess you mean to kill the process.

REPOSITORY
  R449 Plugins for Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29788

To: nikolaik, #dolphin, #vdg, elvisangelaccio, meven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200516/c6cba1cf/attachment.htm>