D29488: Added VCS plugins signals connections for outOfVersionControl() actions.

[Nikolai Krasheninnikov]

nikolaik added inline comments.

INLINE COMMENTS

> meven wrote in versioncontrolobserver.cpp:196
> So this happens when a directory was previously versioned ?

This happens for currently unversioned directory for any reason.

> meven wrote in versioncontrolobserver.cpp:207
> Those lines are present line 178, we could avoid the repetition maybe.
> It seems we can make those connect at plugin instantiation.

We can connect all signals (even `itemVersionsChanged`) on plugin creation. This is a more straightforward way, its simpler. No need of this "disconnect all - connect needed" every time on directory update.
On the other hand this changes current behavior, might be difficult to debug finding signal sender, broken plugin may broke everything else.
But we are in control of dolphin-plugins aren't we?

Nice idea, i will code it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29488

To: nikolaik, #dolphin, meven, elvisangelaccio
Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200515/25a8496c/attachment.htm>