D29488: Added VCS plugins signals connections for outOfVersionControl() actions.

Méven Car noreply at phabricator.kde.org
Fri May 15 12:12:42 BST 2020


meven added inline comments.

INLINE COMMENTS

> versioncontrolobserver.cpp:196
> +        if (m_versionedDirectory) {
> +            m_versionedDirectory = false;
>  

So this happens when a directory was previously versioned ?

> versioncontrolobserver.cpp:207
> +        for (const auto &plugin : qAsConst(m_plugins)) {
> +            connect(plugin.first, &KVersionControlPlugin::infoMessage,
> +                    this, &VersionControlObserver::infoMessage);

Those lines are present line 178, we could avoid the repetition maybe.
It seems we can make those connect at plugin instantiation.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29488

To: nikolaik, #dolphin, meven, elvisangelaccio
Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200515/92aa6dd1/attachment.htm>


More information about the kfm-devel mailing list