D29006: Allow to copy or move selection to the other split view

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Actually sorry, I have a few more comments before I think this can land:

INLINE COMMENTS

> dolphintabwidget.h:196
> +    /** Moves all selected items to the other view. */
> +    void moveToOtherView();
> +

"the other view" is not very informative. How about `{move,copy}ToInactiveSplitView()`, to mirror the name of the action itself?

> dolphinui.rc:2
>  <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
> -<kpartgui name="dolphin" version="30">
> +<kpartgui name="dolphin" version="32">
>      <MenuBar>

bump to 31, not 32

> dolphinview.h:377
> +     */
> +    void copySelectedItems(const KFileItemList &selection, const QUrl &destinationUrl);
> +

ditto for the names here

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29006

To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200514/5c4c4f57/attachment.htm>