D29562: KDirectoryContentsCounter: Avoid scanning twice the same dir, prioritise path not in cache

[Méven Car]

meven added a comment.


  In D29562#670167 <https://phabricator.kde.org/D29562#670167>, @feverfew wrote:
  
  > Hmmmm, this looks like a poor man's priority queue, would `std::priority_queue` not be appropriate here? (I'm not blocking here, idm tbh but it just seems more natural here to me). Also means that you don't have to explicitly enforce it all the time the queues are used, the priority is decided only in one place.
  
  
  It is not a poor man `std::priority_queue`, because a `std::priority_queue` isn't really needed: the value we separate on is just a bit.
  And It is not directly usable since I would need to keep this bit somewhere, and has not the required API : it does not have a contains function.

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29562

To: meven, #dolphin, elvisangelaccio, ngraham
Cc: feverfew, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200513/a0d2e3b2/attachment.htm>