D29488: Added VCS plugins signals connections for outOfVersionControl() actions.

Nikolai Krasheninnikov noreply at phabricator.kde.org
Tue May 12 07:45:22 BST 2020


nikolaik marked 3 inline comments as done.
nikolaik added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in versioncontrolobserver.cpp:171
> What do you mean with "connect needed after" ?
> 
> Btw I'd write "Disconnect every plugin"

Then better without comment at all: code is self-explaining here.
The purpose of the comment was to show the idea: we disconnect and connect later.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29488

To: nikolaik, #dolphin, meven, elvisangelaccio
Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200512/bb22d8f1/attachment.htm>


More information about the kfm-devel mailing list