D29488: Added VCS plugins signals connections for outOfVersionControl() actions.

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> versioncontrolobserver.cpp:171
>  
> -    if (m_plugin) {
> -        m_plugin->disconnect(this);
> +    // Disconnect everything and connect needed after.
> +    for (const auto &i : qAsConst(m_plugins)) {

What do you mean with "connect needed after" ?

Btw I'd write "Disconnect every plugin"

> versioncontrolobserver.cpp:172
> +    // Disconnect everything and connect needed after.
> +    for (const auto &i : qAsConst(m_plugins)) {
> +        i.first->disconnect(this);

Please call the variable `plugin`.

> versioncontrolobserver.cpp:207
> +        // KVersionControlPlugin::outOfVersionControlActions() with appropriate messages.
> +        for (const auto &i : qAsConst(m_plugins)) {
> +            connect(i.first, &KVersionControlPlugin::infoMessage,

Same here.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29488

To: nikolaik, #dolphin, meven, elvisangelaccio
Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200511/bcfe8102/attachment.htm>