[dolphin] [Bug 420312] Dolphin services not being remove after uninstall

[Alex]

https://bugs.kde.org/show_bug.cgi?id=420312

Alex <alexander.lohnau at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://cgit.kde.org/knewst |https://commits.kde.org/kne
                   |uff.git/commit/?id=4c6b3afc |wstuff/a2ecdd333c492d3e4be5
                   |d80a7b03e0381e2a5c8bb693a8f |c21301374073784f1b60
                   |916fd                       |

--- Comment #13 from Alex <alexander.lohnau at gmx.de> ---
Git commit a2ecdd333c492d3e4be5c21301374073784f1b60 by Alexander Lohnau.
Committed on 11/05/2020 at 18:39.
Pushed by alex into branch 'master'.

Do not mark entry as uninstalled if uninstallation script failed

Summary:
As described in the bug report the uninstallation failed, but the
service was marked as removed. Now the service gets only marked as
uninstalled if the script runs without an error. If there is an error
the user gets a popup.

Depends on D29101

Test Plan:
Set the exit code to 1 and try to install a dolphin plugin.
You should get an error message.

Without modifying the exit code you should be able to install services.

The manual deletion can be tested by removing the installed service file. for
example:
rm ~/.local/share/kservices5/ServiceMenus/iso_mounter_unmounter.desktop
Then the uninstaller will crash:
"Failed to remove .desktop file ... No such file or directory"
Then you delete the installed file manually:
rm ~/.local/share/servicemenu-download/iso_mounter_unmounter.desktop
And now you can click the uninstall button and it gets removed
from the list of installed services.

Reviewers: #knewstuff, meven, ngraham, leinir

Reviewed By: #knewstuff, ngraham, leinir

Subscribers: leinir, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D29123

M  +1    -3    src/core/engine.cpp
M  +41   -10   src/core/installation.cpp
M  +3    -3    src/core/installation.h

https://commits.kde.org/knewstuff/a2ecdd333c492d3e4be5c21301374073784f1b60

-- 
You are receiving this mail because:
You are on the CC list for the bug.