D29560: Dolphin: Cleanup service settings page

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> servicessettingspage.cpp:127-128
>          } else if (service == QLatin1String(DeleteService)) {
> -            KSharedConfig::Ptr globalConfig = KSharedConfig::openConfig(QStringLiteral("kdeglobals"), KConfig::NoGlobals);
> +            KSharedConfig::Ptr
> +                globalConfig = KSharedConfig::openConfig(QStringLiteral("kdeglobals"), KConfig::NoGlobals);
>              KConfigGroup configGroup(globalConfig, "KDE");

Please no, this looks really bad.

I'd just revert all these line splittings honestly. What's the gain?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29560

To: alex, #dolphin, ngraham, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200511/a856783d/attachment.htm>