D29560: Dolphin: Cleanup service settings page

[Nathaniel Graham]

ngraham added a comment.


  +1 overall, though I'm not sure changing those things to `auto` is needed or beneficial.

INLINE COMMENTS

> servicessettingspage.cpp:61
>  
> -    QLabel* label = new QLabel(i18nc("@label:textbox",
> -                                     "Select which services should "
> -                                     "be shown in the context menu:"), this);
> +    auto *label = new QLabel(i18nc("@label:textbox",
> +                                   "Select which services should "

Not sure changing these to `auto` is needed

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29560

To: alex, #dolphin, ngraham
Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200511/ffbc300f/attachment.htm>