D29489: [svn] Added SVN Checkout dialog.

[Méven Car]

meven added a comment.


  I think you can land it, code is nice and changes should be consensual.

INLINE COMMENTS

> svncheckoutdialog.cpp:67
> +     */
> +    QObject::connect(m_ui.pbCancel, &QPushButton::clicked, this, &QWidget::close);
> +    QAction *pickDirectory = m_ui.leCheckoutDir->addAction(QIcon::fromTheme("folder"), QLineEdit::TrailingPosition);

Do you really need `QObject::` here ?

> svncheckoutdialog.cpp:69
> +    QAction *pickDirectory = m_ui.leCheckoutDir->addAction(QIcon::fromTheme("folder"), QLineEdit::TrailingPosition);
> +    QObject::connect(pickDirectory, &QAction::triggered, this, [this] () {
> +        const QString dir = QFileDialog::getExistingDirectory(this, i18nc("@title:window", "Choose a directory to checkout"),

And here ?

REPOSITORY
  R449 Plugins for Dolphin

BRANCH
  svn_checkout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29489

To: nikolaik, #vdg, #dolphin, meven, elvisangelaccio, ngraham
Cc: anthonyfieroni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200511/fe2011a7/attachment.htm>