D29489: [svn] Added SVN Checkout dialog.

[Méven Car]

meven added a comment.


  A couple of minor points, but this looks great already.

INLINE COMMENTS

> svncheckoutdialog.cpp:72
> +    if (QUrl(repoPath, QUrl::StrictMode).isValid()) {
> +        m_ui.leRepository->setText(repoPath);
> +    } else {

Check that repoPath looks like a remote svn repo url with schemes svn:/ https:/ or http:/ (can svn use others ?)

> svncheckoutdialog.cpp:73
> +        m_ui.leRepository->setText(repoPath);
> +    } else {
> +        m_ui.leCheckoutDir->setText(m_dir);

Don't need to else here.
A user might have the url in the clipboard and the target dir selected.

> svncheckoutdialog.cpp:90
> +        }
> +        const QString suffix = QDir::separator() + rstrip(text).section('/', astart, astart);
> +

Can reuse variable `stripped`

REPOSITORY
  R449 Plugins for Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29489

To: nikolaik, #vdg, #dolphin, meven, elvisangelaccio, ngraham
Cc: anthonyfieroni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200507/0f7f39ab/attachment.htm>