D25335: [Details mode] Allow to fill the column size of directories with actual size

[Elvis Angelaccio]

elvisangelaccio added a comment.


  @meven Can you please also fix these issues?

INLINE COMMENTS

> viewsettingstab.cpp:186-187
>          DetailsModeSettings::setExpandableFolders(m_expandableFolders->isChecked());
> +        DetailsModeSettings::setDirectorySizeCount(m_numberOfItems->isChecked());
> +        DetailsModeSettings::setRecursiveDirectorySizeLimit(m_recursiveDirectorySizeLimit->value());
>          break;

This will crash on Windows since these member variables are never initialized on that platform.

> viewsettingstab.cpp:236-243
> +        if (DetailsModeSettings::directorySizeCount()) {
> +            m_numberOfItems->setChecked(true);
> +            m_recursiveDirectorySizeLimit->setEnabled(false);
> +        } else {
> +            m_sizeOfContents->setChecked(true);
> +            m_recursiveDirectorySizeLimit->setEnabled(true);
> +        }

Same for this.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25335

To: meven, elvisangelaccio, ngraham, #dolphin
Cc: feverfew, anthonyfieroni, iasensio, kfm-devel, azyx, nikolaik, pberestov, aprcela, fprice, fbampaloukas, alexde, Codezela, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200505/4cc17db2/attachment.htm>