D25335: [Details mode] Allow to fill the column size of directories with actual size

Elvis Angelaccio noreply at phabricator.kde.org
Mon May 4 18:17:13 BST 2020 

elvisangelaccio added a comment.


  This also broke the Windows build on the CI:
  
    07:29:32  FAILED: src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kdirectorycontentscounterworker.cpp.obj 
    07:29:32  C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\cl.exe  /nologo /TP -DKCOREADDONS_LIB -DKF_DEPRECATED_WARNINGS_SINCE=0x060000 -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DEPRECATED_WARNINGS_SINCE=0x060000 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_URL_CAST_FROM_STRING -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_XML_LIB -DTRANSLATION_DOMAIN=\"dolphin\" -DUNICODE -DWIN32_LEAN_AND_MEAN -DWINVER=0x0600 -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D_USE_MATH_DEFINES -D_WIN32_IE=0x0600 -D_WIN32_WINNT=0x0600 -Ddolphinprivate_EXPORTS -Isrc -I..\src -Isrc\dolphinprivate_autogen\include -IC:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5 -IC:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtWidgets -IC:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtGui -IC:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtANGLE -IC:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtCore -IC:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\.\mkspecs\win32-msvc -IC:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtConcurrent -I"C:\CI\Software Installs\dolphin\include\KF5\KI18n" -I"C:\CI\Software Installs\dolphin\include\KF5" -I"C:\CI\Software Installs\dolphin\include\KF5\KIconThemes" -I"C:\CI\Software Installs\dolphin\include\KF5\KIOCore" -I"C:\CI\Software Installs\dolphin\include\KF5\KCoreAddons" -I"C:\CI\Software Installs\dolphin\include\KF5\KService" -I"C:\CI\Software Installs\dolphin\include\KF5\KConfigCore" -IC:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtNetwork -IC:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtDBus -I"C:\CI\Software Installs\dolphin\include\KF5\KIOWidgets" -I"C:\CI\Software Installs\dolphin\include\KF5\KIOGui" -I"C:\CI\Software Installs\dolphin\include\KF5\KWindowSystem" -I"C:\CI\Software Installs\dolphin\include\KF5\KJobWidgets" -I"C:\CI\Software Installs\dolphin\include\KF5\KCompletion" -I"C:\CI\Software Installs\dolphin\include\KF5\KWidgetsAddons" -I"C:\CI\Software Installs\dolphin\include\KF5\KIOFileWidgets" -I"C:\CI\Software Installs\dolphin\include\KF5\KBookmarks" -IC:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\include\qt5\QtXml -I"C:\CI\Software Installs\dolphin\include\KF5\KItemViews" -I"C:\CI\Software Installs\dolphin\include\KF5\KXmlGui" -I"C:\CI\Software Installs\dolphin\include\KF5\KConfigWidgets" -I"C:\CI\Software Installs\dolphin\include\KF5\KCodecs" -I"C:\CI\Software Installs\dolphin\include\KF5\KConfigGui" -I"C:\CI\Software Installs\dolphin\include\KF5\KAuth" -I"C:\CI\Software Installs\dolphin\include\KF5\Solid" -I"C:\CI\Software Installs\dolphin\include\KF5\KTextWidgets" -I"C:\CI\Software Installs\dolphin\include\KF5\SonnetUi" -I"C:\CI\Software Installs\dolphin\include\KF5\KNewStuff3" -I"C:\CI\Software Installs\dolphin\include\KF5\KNewStuff3\KNS3" -I"C:\CI\Software Installs\dolphin\include\KF5\KNewStuff3\knscore" -I"C:\CI\Software Installs\dolphin\include\KF5\KNewStuff3\kns3" -I"C:\CI\Software Installs\dolphin\include\KF5\KNewStuff3\KNSCore" -I"C:\CI\Software Installs\dolphin\include\KF5\Attica" -I"C:\CI\Software Installs\dolphin\include\KF5\KParts" -I"C:\CI\Software Installs\dolphin\include\KF5\KFileMetaData" -I"C:\CI\Software Installs\dolphin\include\KF5\Baloo" -I"C:\CI\Software Installs\dolphin\include\KF5\BalooWidgets" /DWIN32 /D_WINDOWS /W3 /GR /EHsc /wd4250 /wd4251 /wd4396 /wd4661 /MDd /Zi /Ob0 /Od /RTC1 /showIncludes /Fosrc\CMakeFiles\dolphinprivate.dir\kitemviews\private\kdirectorycontentscounterworker.cpp.obj /Fdsrc\CMakeFiles\dolphinprivate.dir\ /FS -c ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(42): error C2061: syntax error: identifier 'QT_DIRENT'
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(47): error C3861: 'QT_OPENDIR': identifier not found
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(50): error C2065: 'QT_STATBUF': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(50): error C2146: syntax error: missing ';' before identifier 'buf'
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(50): error C2065: 'buf': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(52): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(52): error C3861: 'QT_READDIR': identifier not found
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(53): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(54): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(58): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(58): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(68): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(68): error C2065: 'DT_DIR': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(69): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(69): error C2065: 'DT_LNK': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(70): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(70): error C2065: 'DT_UNKNOWN': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(67): error C2789: 'countEntry': an object of const-qualified type must be initialized
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(67): note: see declaration of 'countEntry'
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(75): error C2065: 'allowedRecursiveLevel': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(78): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(80): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(80): error C2065: 'DT_REG': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(80): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(80): error C2065: 'DT_LNK': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(81): error C2065: 'buf': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(81): error C3861: 'QT_STAT': identifier not found
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(82): error C2065: 'buf': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(82): error C3861: 'S_ISDIR': identifier not found
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(86): error C2065: 'buf': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(89): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(89): error C2065: 'DT_DIR': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(91): error C2065: 'dirEntry': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(91): error C2065: 'allowedRecursiveLevel': undeclared identifier
    07:29:32  ..\src\kitemviews\private\kdirectorycontentscounterworker.cpp(95): error C3861: 'QT_CLOSEDIR': identifier not found
  
  Can you have a look @meven ?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25335

To: meven, elvisangelaccio, ngraham, #dolphin
Cc: feverfew, anthonyfieroni, iasensio, kfm-devel, azyx, nikolaik, pberestov, aprcela, fprice, fbampaloukas, alexde, Codezela, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200504/184bee31/attachment.htm>

More information about the kfm-devel mailing list