D29006: Allow to copy or move selection to the other split view

Antonio Prcela noreply at phabricator.kde.org
Sun May 3 21:23:11 BST 2020


aprcela marked 2 inline comments as done.
aprcela added a comment.


  @elvisangelaccio wrote:
  
  copySelectedItems() is already used to copy to clipboard. See L365.
  
  @meven I uploadaded the currently working code (to check if destination is writable for the copy function). But I can't get it to work for the location you provided: `recentlyused:/files/`

INLINE COMMENTS

> elvisangelaccio wrote in dolphinview.cpp:1222
> I see.
> 
> @aprcela Can you add this information in the commit message? Otherwise it will get lost.

It's in the commit 5359352b0ef1. Is that enough?

> elvisangelaccio wrote in dolphinview.h:367-377
> Nitpick: `DolphinView` doesn't know what a "split view" is. I'd rather call these methods `copySelectedItems()` and `moveSelectedItems()`, since that's what they are actually doing.

`copySelectedItems()` is already used to copy to clipboard. See L365.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29006

To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200503/1f5ebb01/attachment.htm>


More information about the kfm-devel mailing list