D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.


  Please fix the last two inline comments and then feel free to ship it.

INLINE COMMENTS

> CMakeLists.txt:88-90
> +else()
> +    set(HAVE_PACKAGEKIT FALSE)
> +endif()

Not needed, this is the default ;)

> CMakeLists.txt:10
>  )
> +configure_file(config-packagekit.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-packagekit.h)
> +

Please move it to `src/CMakeLists.txt`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29119

To: alex, #dolphin, ngraham, elvisangelaccio, meven
Cc: cblack, anthonyfieroni, asturmlechner, meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200503/4d31b10d/attachment.htm>