D25335: [Details mode] Allow to fill the column size of directories with actual size

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> meven wrote in kfileitemmodelrolesupdater.cpp:770-774
> To allow the slotItemsChanged to be called when new data about fileSize arrives.
> It is needed to have progressive ordering of folder while the worker is walking through the directories.
> Otherwise the view does refresh the column size as the results arrives.
> The view is still updated with a delay to batch UI changes (m_recentlyChangedItemsTimer).

I see. Please do mention this "progressive ordering" in the commit message.

> meven wrote in kdirectorycontentscounter.cpp:70
> I intend to have a single worker KDirectoryContentsCounter, so why bother reimplementing a refCount ?

I see. This is valuable information, please put it in the commit message :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25335

To: meven, elvisangelaccio, ngraham, #dolphin
Cc: feverfew, anthonyfieroni, iasensio, kfm-devel, azyx, nikolaik, pberestov, aprcela, fprice, fbampaloukas, alexde, Codezela, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200503/f1db27a9/attachment.htm>