D29115: Add option to show hidden files and folders last

Elvis Angelaccio noreply at phabricator.kde.org
Sun May 3 18:07:54 BST 2020


elvisangelaccio added a comment.


  In D29115#660130 <https://phabricator.kde.org/D29115#660130>, @harogaston wrote:
  
  > In D29115#658465 <https://phabricator.kde.org/D29115#658465>, @meven wrote:
  >
  > > About testing, you need to install the tool `ctest` then go to build dir and run the whole tests with `ctest` (it has many options to be more clever for instance `ctest -R kfileitemmodeltest`
  >
  >
  > Thank you for the info. I will try to add a test then.
  >
  > In D29115#657937 <https://phabricator.kde.org/D29115#657937>, @elvisangelaccio wrote:
  >
  > > In D29115#655601 <https://phabricator.kde.org/D29115#655601>, @harogaston wrote:
  > >
  > > > Well for me it is pretty clear that this should be at least an option, if not the default. If you don't work with hidden files visible then this does nothing. But if you do, like myself, which view do you think is more useful/productive
  > >
  > >
  > > Right, so let's make it the default without adding an option to get a worse behavior ;)
  >
  >
  > So do you all want me to remove all the clutter code regarding the new setting and just keep the logic as to make it the default and only behavior? 
  >  I would rather very much keep the extra option. But it is up to you I guess.
  
  
  You said it yourself: every setting needs a good amount of clutter code, which makes the overall codebase harder to test and harder to maintain. That's why we try to avoid adding a new setting every time we add a new feature.
  
  We can reconsider if enough people complain about this new behavior not being optional.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29115

To: harogaston, #dolphin, ngraham, elvisangelaccio
Cc: meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200503/5d69483e/attachment.htm>


More information about the kfm-devel mailing list