D28402: Provide ability to configure size cut-off for local file previews

[Méven Car]

meven added a comment.


  In D28402#661396 <https://phabricator.kde.org/D28402#661396>, @harogaston wrote:
  
  > > Please push your changes.
  > >  Another text would be "Preview Disabled", "Never Preview" but "No Preview" for remote files seems better to me.
  > >  And for local files "No Size limit" ?
  >
  > Hi! I'm ok with whichever text we decide to go with but I don't understand why you suggested using different ones for each spin-box.
  >  Functionality is exactly the same for both files categories.
  
  
  In fact they are not :
  When 0 is set for remote file spinbox it means that only remote files a file smaller than 0 will get a preview (i.e never).
  When 0 is set for local file spinbox it means that all local files file will get a preview because in that case we set `IgnoreMaximumSize` :
  
    job->setIgnoreMaximumSize(itemSubSet.first().isLocalFile() && m_localFileSizePreviewLimit <= 0
  
  This inverse the meaning of the value 0 basically. (The KPreviewJob use the max int value as default for MaximumSize, meaning all local files should have a preview).
  If this line was not set, it would be true.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D28402

To: harogaston, ngraham, #dolphin, meven, elvisangelaccio
Cc: cfeck, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200502/eef20a33/attachment.htm>