D29345: Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed.
Nikolai Krasheninnikov
noreply at phabricator.kde.org
Fri May 1 18:55:00 BST 2020
nikolaik created this revision.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
nikolaik requested review of this revision.
REVISION SUMMARY
Dolphin crashes if no Konsole is installed and user clicks menu action "Defocus Teminal Panel".
This fix is pretty straight forward.
Steps to reproduce:
1. Run Dolphin without Konsole available.
2. Press F4 <https://phabricator.kde.org/F4> to open console window.
3. Click in service menu "Focus Teminal Panel".
4. Click in service menu "Defocus Terminal Panel". Observe the crash.
TEST PLAN
1. Run Dolphin without Konsole available.
2. Press F4 <https://phabricator.kde.org/F4> to open console window.
3. Click in service menu "Focus Teminal Panel".
4. Click in service menu "Defocus Terminal Panel".
5. Click in service menu "Focus Teminal Panel".
6. Press F4 <https://phabricator.kde.org/F4> to close console window.
REPOSITORY
R318 Dolphin
BRANCH
fix-dolphin-crush (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29345
AFFECTED FILES
src/panels/terminal/terminalpanel.cpp
To: nikolaik
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200501/6c7db697/attachment.htm>
More information about the kfm-devel
mailing list