D29321: Port and enable the User Agent Changer plugin

Jonathan Marten noreply at phabricator.kde.org
Fri May 1 11:05:15 BST 2020


marten created this revision.
marten added reviewers: Konqueror, Plasma.
marten requested review of this revision.

REVISION SUMMARY
  The plugin is ported to use Qt5 and KF5, including:
  
  - Install rc file in additionally for WebEngine
  - Fix up include files
  - Use new Qt connect syntax
  - Conditionalise Qt::SkipEmptyParts/QString::SkipEmptyParts ready for 5.15
  - Use QUrl::topLevelDomain() in findTLD()
  
  Note that a fix for D28647 <https://phabricator.kde.org/D28647> needs to be incorporated into KIO, as otherwise the user agent can only be changed once.

TEST PLAN
  Built Konqueror with this change and the initial fix from D28647 <https://phabricator.kde.org/D28647>.  Tested with https://kluge.in-chemnitz.de/tools/browser.php to demonstrate that selecting a user agent from the menu changes the resulting HTTP header sent.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D29321

AFFECTED FILES
  plugins/CMakeLists.txt
  plugins/uachanger/CMakeLists.txt
  plugins/uachanger/uachangerplugin.cpp
  plugins/uachanger/uachangerplugin.h

To: marten, #konqueror, #plasma
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200501/86cba5cc/attachment.htm>


More information about the kfm-devel mailing list