D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

Ahmad Samir noreply at phabricator.kde.org
Thu Mar 26 09:58:40 GMT 2020


ahmadsamir added a comment.


  In D28161#634949 <https://phabricator.kde.org/D28161#634949>, @sitter wrote:
  
  > Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :((
  
  
  Unit tests are indeed useful...
  
  > Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client
  
  That's confusing; but OK, I'll revert that part of the diff.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28161

To: ahmadsamir, dfaure, sitter, apol
Cc: kfm-devel, kde-frameworks-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200326/38aa19f0/attachment.htm>


More information about the kfm-devel mailing list