D28227: Use same logic for "no extension" case with Duplicate feature
Nathaniel Graham
noreply at phabricator.kde.org
Mon Mar 23 19:52:40 GMT 2020
ngraham created this revision.
ngraham added reviewers: Dolphin, elvisangelaccio, arojas, meven.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
ngraham requested review of this revision.
REVISION SUMMARY
In the "no extension" case, we weren't separating out the path and the original filename,
breaking the feature for languages where the word "copy" would be at the beginning of the
filename, not after it (e.g. "copia de foo" in Spanish, and similar in other romance
languages). This patch fixes that by separating the original path and filename in the no
extension case as is done for the other case, which should solve the issue.
BUG: 419070
FIXED-IN: 20.04.0
TEST PLAN
No changes in English; should fix the issue in Spanish once new translations are done
(see https://bugs.kde.org/show_bug.cgi?id=419070 for details)
REPOSITORY
R318 Dolphin
BRANCH
fix-duplicate-with-various-languages (branched from release/20.04)
REVISION DETAIL
https://phabricator.kde.org/D28227
AFFECTED FILES
src/views/dolphinview.cpp
To: ngraham, #dolphin, elvisangelaccio, arojas, meven
Cc: kfm-devel, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200323/ae9568b5/attachment.htm>
More information about the kfm-devel
mailing list